Skip to content

Commit

Permalink
[Python] Update generated code warning version (grpc#37229)
Browse files Browse the repository at this point in the history
Push back the date of changing warning to error in case so that it won't be a blocker for CSM launch.
<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes grpc#37229

PiperOrigin-RevId: 652924647
  • Loading branch information
XuanWang-Amos authored and copybara-github committed Jul 16, 2024
1 parent ebc0395 commit 4ad050e
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 6 deletions.
12 changes: 11 additions & 1 deletion examples/python/helloworld/helloworld_pb2.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions examples/python/helloworld/helloworld_pb2_grpc.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@

import helloworld_pb2 as helloworld__pb2

GRPC_GENERATED_VERSION = '1.64.0.dev0'
GRPC_GENERATED_VERSION = '1.66.0.dev0'
GRPC_VERSION = grpc.__version__
EXPECTED_ERROR_RELEASE = '1.65.0'
SCHEDULED_RELEASE_DATE = 'June 25, 2024'
EXPECTED_ERROR_RELEASE = '1.66.0'
SCHEDULED_RELEASE_DATE = 'August 6, 2024'
_version_not_supported = False

try:
Expand Down
4 changes: 2 additions & 2 deletions src/compiler/python_generator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -744,8 +744,8 @@ bool PrivateGenerator::PrintPreamble(grpc_generator::Printer* out) {
var["ToolsVersion"] = config.grpc_tools_version;
out->Print(var, "\nGRPC_GENERATED_VERSION = '$ToolsVersion$'\n");
out->Print("GRPC_VERSION = grpc.__version__\n");
out->Print("EXPECTED_ERROR_RELEASE = '1.65.0'\n");
out->Print("SCHEDULED_RELEASE_DATE = 'June 25, 2024'\n");
out->Print("EXPECTED_ERROR_RELEASE = '1.66.0'\n");
out->Print("SCHEDULED_RELEASE_DATE = 'August 6, 2024'\n");
out->Print("_version_not_supported = False\n\n");
out->Print("try:\n");
{
Expand Down

0 comments on commit 4ad050e

Please sign in to comment.