Skip to content
This repository has been archived by the owner on Nov 27, 2018. It is now read-only.

Option doesn't always change on click #47

Open
dahliacreative opened this issue Apr 2, 2014 · 12 comments
Open

Option doesn't always change on click #47

dahliacreative opened this issue Apr 2, 2014 · 12 comments
Labels

Comments

@dahliacreative
Copy link

Hey Guys I'm having an issue where sometimes when you click to change an option nothing happens and you have to click the option 3 times to get it to change.

I'm half way through a massive project and I've only just noticed this.

Any ideas what it could be??

@dahliacreative
Copy link
Author

Ok so it seems if your click takes too long, the event doesn't fire, but if you do a quick click then it does. I don't know if this is intentional, but seems like a bug to me. Obviously I click slowly.

@dahliacreative
Copy link
Author

Ok I figured it it's because you're triggering close.fs whenever the select is blurred.

So I removed the blur event on the select then in the options.click.fs event just triggered close.fs and that seemed to fix it.

Need to make sure it works on iOS but it works much better for me on desktop now, is there a reason you guys did it that way? I'm just thinking about old users who might make longer clicks like my dad!

If there is no major breakage after changing it, I'll submit a pull request. Cheers.

EDIT: Just realised why you've done this, so if you click off without selecting an option. Hmmm. Frustrating!

@dahliacreative
Copy link
Author

Ok I got round it with a mouseenter/mouseleave function on the options to set a isHovered var which I check when the sel is blurred. Does the trick.

@paulstraw paulstraw added the bug label Apr 2, 2014
@justiny
Copy link

justiny commented Apr 20, 2014

Has the fix been implemented? I'm noticing it still on my application of it. No change on click.

@dahliacreative
Copy link
Author

I just implemented my own fix, along with some others, I'll commit it to my for and submit a pull request.

@justiny
Copy link

justiny commented Apr 25, 2014

That would be really helpful, thanks.

@dahliacreative
Copy link
Author

I've submitted a pull request, although it doesn't seem like anyone is working on it as the last pull requests were from 3 months ago.

FYI In my pull request I also re-ordered the elements in the fancy-select div so the select now comes last which fixes the positioning of validation messages if you are using something like parsley.js

@paulstraw
Copy link
Owner

We're here. Sorry about the delays, things have been very busy on our end. Have you tested your fix on iOS/Android?

@dahliacreative
Copy link
Author

I've tested on iOS, but not android as I don't have anything to test it on :(

@smercadomx
Copy link

I was having the same problem, pull request from @sjoudry fixed it for me. Thanks

@hbi99
Copy link

hbi99 commented May 7, 2015

+1

@Kirill380
Copy link

Thank you a lot, it works)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants