Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMPATIBILITY: resolve deprecations expected in Ember upgrade for Discourse 3.2 #267

Merged
merged 20 commits into from
Sep 15, 2023
Merged

COMPATIBILITY: resolve deprecations expected in Ember upgrade for Discourse 3.2 #267

merged 20 commits into from
Sep 15, 2023

Conversation

merefield
Copy link
Member

@merefield merefield commented Sep 14, 2023 •
edited
Loading

Fixes various deprecations related to Route service use refactor but also:

  • COMPATIBILITY: moves two modals to new Component system
  • COMPATIBILITY: modernises those those Components to Glimmer
  • IMPROVES: fixes a couple of spelling mistakes in tests
  • FIX: fixes a couple of front end tests.

@merefield merefield changed the title COMPATIBILITY: Add this to avoid deprecation COMPATIBILITY: a set of changes to resolve deprecations expected in Ember upgrade for 3.2 Sep 14, 2023
@merefield merefield changed the title COMPATIBILITY: a set of changes to resolve deprecations expected in Ember upgrade for 3.2 COMPATIBILITY: resolve deprecations expected in Ember upgrade for Discourse 3.2 Sep 14, 2023
angusmcleod
angusmcleod requested changes Sep 14, 2023
View reviewed changes
Copy link
Member

@angusmcleod angusmcleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@merefield Just one very minor change and I'll merge.

assets/javascripts/discourse/controllers/admin-wizards-wizard-show.js.es6 Outdated Show resolved Hide resolved
@merefield
Copy link
Member Author

merefield commented Sep 15, 2023 •
edited
Loading

@angusmcleod resolved, good catch, apologies for that, unintentional.

@angusmcleod angusmcleod self-requested a review September 15, 2023 06:55
@angusmcleod angusmcleod merged commit 5f99dc2 into main Sep 15, 2023
5 checks passed
@angusmcleod angusmcleod deleted the resolve_deprecations branch September 15, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angusmcleod angusmcleod angusmcleod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merefield @angusmcleod