Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer control feature #269

Merged
merged 15 commits into from
Sep 21, 2023
Merged

Composer control feature #269

merged 15 commits into from
Sep 21, 2023

Conversation

jumagura
Copy link
Member

@jumagura jumagura commented Sep 18, 2023

This PR is adds two features to improve topic management when a custom wizard replaces the composer:

  1. Backend control to block direct topic creation in specified categories.

image

  1. A frontend setting to hide categories from the composer dropdown.

image

Awaiting review from @angusmcleod

@jumagura
Copy link
Member Author

jumagura commented Sep 19, 2023

frontend setting to hide categories was removed and the category will be hidden from composer dropdown by default

Copy link
Member

@angusmcleod angusmcleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jumagura We're getting close! Just one small change and this will be ready.

lib/custom_wizard/extensions/topic_extension.rb Outdated Show resolved Hide resolved
@jumagura
Copy link
Member Author

Changes requested done 😃

@angusmcleod
Copy link
Member

angusmcleod commented Sep 20, 2023

@jumagura just checking that the PR is not intended to do the second item anymore?

A frontend setting to hide categories from the composer dropdown.

@jumagura
Copy link
Member Author

that is correct. that setting is removed

@angusmcleod angusmcleod merged commit 578c92e into main Sep 21, 2023
5 checks passed
@angusmcleod angusmcleod deleted the composer-control-feature branch September 21, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants