Encode s3 keys in source_url

paviliondev · Oct 25, 2024 · b03309a · b03309a
1 parent 0286d33
commit b03309a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/app/models/subscription_client_resource.rb b/app/models/subscription_client_resource.rb
@@ -11,7 +11,7 @@ def get_source_url(bucket)
     return nil unless access_key_id && secret_access_key && s3_client
     return nil unless can_access_bucket?(bucket)
 
-    "s3://#{access_key_id}:#{secret_access_key}@#{bucket}"
+    "s3://#{CGI.escapeURIComponent(access_key_id)}:#{CGI.escapeURIComponent(secret_access_key)}@#{bucket}"
   end
 
   def can_access_bucket?(bucket)