FEATURE: allow authorisation call to determine final landing path #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angusmcleod
requested changes
Sep 20, 2023
There was a problem hiding this comment.
@merefield lets add a test in and then it'll be ready for merging at the appropriate time.
tests added |
angusmcleod
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make this gem permit individual plugins to complete an authorisation loop, it must offer a definable final landing path for the authorisation process.
it's currently the subscription client subscriptions list which obviously won't exist!
Allow this to be changed by inclusion of a parameter in the authorize method of the Suppliers Controller to tailor it for each individual plugin leveraging the gem.