Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[F] Fix GitHub Actions trigger issues. #101

Merged
merged 1 commit into from
Feb 8, 2021
Merged

[F] Fix GitHub Actions trigger issues. #101

merged 1 commit into from
Feb 8, 2021

Conversation

VergeDX
Copy link
Contributor

@VergeDX VergeDX commented Feb 8, 2021

@pavlobu
I move previous homebrew-pr actions to another action, the trigger condition is "on released".
I hope it can fix the previous mistake...

@codecov-io
Copy link

Codecov Report

Merging #101 (dc04ece) into master (dee1213) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   64.29%   64.29%           
=======================================
  Files         131      131           
  Lines        2140     2140           
  Branches      206      206           
=======================================
  Hits         1376     1376           
  Misses        628      628           
  Partials      136      136           
Flag Coverage Δ
unittests 64.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee1213...dc04ece. Read the comment docs.

@VergeDX
Copy link
Contributor Author

VergeDX commented Feb 8, 2021

Wait, What is ${GITHUB_REF##*/} after released...? Let me test.

@VergeDX VergeDX marked this pull request as draft February 8, 2021 02:33
@pavlobu
Copy link
Owner

pavlobu commented Feb 8, 2021

Wait, What is ${GITHUB_REF##*/} after released...? Let me test.

last time when I did Re-run all jobs it did fine with that syntax:
https://github.com/pavlobu/deskreen/runs/1850557736?check_suite_focus=true

and homebrew update was published and merged:
Homebrew/homebrew-cask#99488

@VergeDX
Copy link
Contributor Author

VergeDX commented Feb 8, 2021

Behavior not change, I think that's right.
I just testing on a empty repo VergeDX/Test_GitHub_Actions.

@VergeDX VergeDX marked this pull request as ready for review February 8, 2021 12:12
@pavlobu
Copy link
Owner

pavlobu commented Feb 8, 2021

@VergeDX thank you very much! merging 🎉

@pavlobu pavlobu merged commit 7f0ca45 into pavlobu:master Feb 8, 2021
@VergeDX
Copy link
Contributor Author

VergeDX commented Feb 8, 2021

<3

@pavlobu
Copy link
Owner

pavlobu commented Feb 20, 2021

Hi @VergeDX
When I released v1.0.6 there were some problems while during your homebrew task:
https://github.com/pavlobu/deskreen/runs/1942855611?check_suite_focus=true#step:4:210

do you happen to know what went wrong?
Cheers

@VergeDX
Copy link
Contributor Author

VergeDX commented Feb 24, 2021

@pavlobu Oh, I know what's wrong!
See Homebrew/brew/pull/10568, now HOMEBREW_GITHUB_API_TOKEN need a extra permission "workflow".
I will PR fixes now, please delete the old Homebrew token, add a new token by open this link:
https://github.com/settings/tokens/new?scopes=gist,public_repo,workflow&description=Homebrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants