Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[U] Update comment of HOMEBREW_GITHUB_API_TOKEN's scope. #123

Merged
merged 1 commit into from
Feb 25, 2021
Merged

[U] Update comment of HOMEBREW_GITHUB_API_TOKEN's scope. #123

merged 1 commit into from
Feb 25, 2021

Conversation

VergeDX
Copy link
Contributor

@VergeDX VergeDX commented Feb 24, 2021

Now we should add the "workflow" scope into HOMEBREW_GITHUB_API_TOKEN.
Otherwise, it will go wrong like pavlobu/deskreen/runs/1942855611?check_suite_focus=true#step:4:210.
Homebrew's changes: Homebrew/brew/pull/10568

@pavlobu
Copy link
Owner

pavlobu commented Feb 24, 2021

Great 👍 @VergeDX !
One thing I was thinking on to add then is the ability to manually trigger workflow if such things happen in future, so then I don't have to create a new release just with a workflow fix , to actually trigger homebrew task.

I’ll look into it tomorrow

Cheers,
Paul

@pavlobu pavlobu merged commit afbe6db into pavlobu:master Feb 25, 2021
@VergeDX
Copy link
Contributor Author

VergeDX commented Feb 25, 2021

@pavlobu
Oh, It works! I finally fixed this problem, sorry it took so long.
Homebrew/homebrew-cask/pull/100340

@pavlobu
Copy link
Owner

pavlobu commented Feb 25, 2021

@VergeDX
yes it works!
Thank you a lot! It really helps.

@pavlobu
Copy link
Owner

pavlobu commented Jun 1, 2022

@VergeDX Hi,
seems our Homebrew publish task broke. 🥲
Homebrew/homebrew-cask#124665 (comment)
Do you happen to have any time available to have a look at it?
Thanks!

@VergeDX
Copy link
Contributor Author

VergeDX commented Jun 1, 2022

Eh, I'm not using macOS anymore, but I still will look at this : )

@VergeDX
Copy link
Contributor Author

VergeDX commented Jun 1, 2022

It looks deskreen is already latest 2.0.1 version... 🤔
https://github.com/Homebrew/homebrew-cask/blob/master/Casks/deskreen.rb#L2=

@pavlobu
Copy link
Owner

pavlobu commented Jun 1, 2022

Hmm, yeah, it seems so, indeed.
Sorry for disturbing you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants