Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support notmuch database paths without leading / #1396

Open
polyzen opened this issue May 11, 2019 · 11 comments · May be fixed by #1495
Open

Support notmuch database paths without leading / #1396

polyzen opened this issue May 11, 2019 · 11 comments · May be fixed by #1495

Comments

@polyzen
Copy link
Contributor

polyzen commented May 11, 2019

Is your feature request related to a problem? Please describe.
Avoid storing one's system username in one's dotfiles repo.

Describe the solution you'd like
"Database paths without a leading / are relative to $HOME":
notmuch/notmuch@95a9c73
https://notmuchmail.org/pipermail/notmuch/2019/027762.html
afewmail/afew#233

Describe alternatives you've considered
Tried applying the above patch to notmuch, but that didn't suffice.
@pazz
Copy link
Owner

pazz commented May 12, 2019 •
edited
Loading

I'm not sure what kind of change exactly you want.
Have you seen the -p command line argument to alot?

@polyzen
Copy link
Contributor Author

polyzen commented May 12, 2019

Support relative path for database location

As of notmuch 0.28, a relative path may be provided for the database
location. notmuch prepends $HOME/ to the relative path. For feature
parity, afew now supports the same methodology of prepending $HOME/ if a
relative path is provided.

@pazz
Copy link
Owner

pazz commented May 12, 2019

I find this totally strange tbh: if i pass on -p ../this/or/that as a command line parameter to alot then I'd expect it refers to the given path relative to the current directory, and not $HOME.
If afew nowadays does this differently so be it. I don't really feel responsible to replicate such funky behaviour in the name of consistency.

@polyzen
Copy link
Contributor Author

polyzen commented May 12, 2019

The behavior of -p doesn't have to change, but supporting upstream's handling of the database path makes sense to me.

@pazz
Copy link
Owner

pazz commented May 12, 2019 via email

@polyzen
Copy link
Contributor Author

polyzen commented May 12, 2019

Can't seem to find the alot's path config. I meant the path alot gets from notmuch itself.

@polyzen
Copy link
Contributor Author

polyzen commented May 12, 2019

https://github.com/afewmail/afew/pull/233/files

@polyzen
Copy link
Contributor Author

polyzen commented Sep 18, 2019

Can't seem to find the alot's path config. I meant the path alot gets from notmuch itself.

https://alot.readthedocs.io/en/latest/configuration/config_options.html?highlight=path

Could I be pointed in the right direction?

@pazz
Copy link
Owner

pazz commented Sep 18, 2019 via email

@kirelagin
Copy link

kirelagin commented Apr 19, 2020 •
edited
Loading

I’m surprised this hasn’t been fixed yet :/. Let me give it a shot.

@kirelagin kirelagin linked a pull request Apr 19, 2020 that will close this issue
Open
@pazz
Copy link
Owner

pazz commented May 6, 2020

I guess this relates to #1495 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make notmuch db location logic match upstream kirelagin/alot
3 participants
@kirelagin @pazz @polyzen