Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANSIText makes startup slow #1530

Open
mjg opened this issue Jun 21, 2020 · 4 comments
Open

ANSIText makes startup slow #1530

mjg opened this issue Jun 21, 2020 · 4 comments

Comments

@mjg
Copy link
Contributor

mjg commented Jun 21, 2020

Describe the bug
Startup of alot is very slow (10s instead of <1s) since the last update. I bisected this to:
530addcb ("mimetree-rebase: FocusText -> ANSIText (See #1015)", 2020-02-17)

Software Versions

  • Python version:3.7.7
  • Notmuch version: 0.29
  • Alot version: see above

To Reproduce
Steps to reproduce the behaviour:

  1. start alot

This indicates that message parts are loaded unnecessarily in thread mode, so I do hope that #1523 might help.

@mjg mjg changed the title ANSText makes startup slow ANSIText makes startup slow Jun 21, 2020
@mjg
Copy link
Contributor Author

mjg commented Jun 21, 2020

Update: yes, #1523 greatly helps. Though one could say that it covers up the slowness of the ANSItext widget ...

@pazz
Copy link
Owner

pazz commented Jun 22, 2020

weird. the new widgets did not make anything slow for me. Perhaps it is due to this new patch to interpret plaintext parts via mailcap if defined, and your system is configured to call some slow big converter?
Can you check your mailcaps?

@mjg
Copy link
Contributor Author

mjg commented Jun 22, 2020

Well, I literally bisected this (git bisect) to the commit that I mentioned (with plain pazz/alot, no own patches). So, unless the ANSIText widget uses mailcap and the old one does not this is not related.

In any case, my mailcap has
text/html; elinks -force-html -dump -dump-color-mode 3 -dump-charset utf8 -eval 'set document.codepage.assume = "%{charset}"' %s; copiousoutput
and nothing for plain text, nor does the system mailcap.

Maybe I have too many HTML mails in my inbox and elinks is slow?

@pazz
Copy link
Owner

pazz commented Jun 22, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants