Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening homepage of anyone should cause a new tab to open #15

Open
milindl opened this issue Aug 7, 2017 · 3 comments
Open

Opening homepage of anyone should cause a new tab to open #15

milindl opened this issue Aug 7, 2017 · 3 comments

Comments

@milindl
Copy link

milindl commented Aug 7, 2017

As discussed with @yashsriv

This is an easy issue.

@adarshaj
Copy link
Member

adarshaj commented Aug 7, 2017

Here's a reason why this is a bad idea: https://css-tricks.com/use-target_blank/

@milindl
Copy link
Author

milindl commented Aug 7, 2017

That article makes a lot of good points!

I originally had the issue that navigating away from the page in any way and then pressing the "back" button gets you to the base search page (instead of your search query etc being open.) @yashsriv said that this was the way it was supposed to be if I entered another url manually in the adress bar - but it should not be the case for navigating away by clicking on a link on the page itself (the link in question being the homepage link). That's how we arrived at the solution.

Maybe I should rescope the issue here, so that a consensus can be reached?

@abdatta
Copy link
Contributor

abdatta commented Oct 29, 2017

Maybe we can add query params to the URL so that, on pressing back, we come back to the exact previous search. However, that might make the URL look dirty due to the large no. of possible parameters. Best to have the link open in a separate tab. What do ya' say?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants