Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure the config isn't missing keys when reading it #19

Open
teauxfu opened this issue Apr 28, 2021 · 1 comment
Open

make sure the config isn't missing keys when reading it #19

teauxfu opened this issue Apr 28, 2021 · 1 comment
Labels
enhancement New feature or request refactor Something could be handled better

Comments

@teauxfu
Copy link
Member

teauxfu commented Apr 28, 2021 •
edited
Loading

the way the configuration is currently interfaced with could be improved

keys are currently not validated

could probably trim the dependency on appdirs with an approach like this

https://github.com/pallets/click/blob/8b48450d5d63c747600e069d4c3e2274f41c8360/src/click/utils.py#L412

also see how poetry handles its config
@teauxfu teauxfu added the enhancement New feature or request label Apr 28, 2021
@teauxfu teauxfu changed the title make sure the config isn't missing keys make sure the config isn't missing keys when reading it Jun 1, 2021
@teauxfu
Copy link
Member Author

teauxfu commented Jun 8, 2021

an option is to move the config into a database table #24

@teauxfu teauxfu added the refactor Something could be handled better label Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request refactor Something could be handled better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@teauxfu