Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up report exporting #28

Open
teauxfu opened this issue Jun 8, 2021 · 1 comment
Open

clean up report exporting #28

teauxfu opened this issue Jun 8, 2021 · 1 comment
Labels
refactor Something could be handled better

Comments

@teauxfu
Copy link
Member

teauxfu commented Jun 8, 2021 •
edited
Loading

we have a whole dependency on Pandas for one little call in export helper - could be worked around

https://github.com/teauxfu/scalewiz/blob/d0e1d63871fd3a5595cd265f4c44e2a11196a4b6/scalewiz/helpers/export.py#L80-L83

alternatively, we could keep Pandas and try to make better use of it

pandas.normalize_json should help with flattening dicts for the sake of exporting a file that can be easily read by excel

see also #24
@teauxfu teauxfu added the refactor Something could be handled better label Jun 8, 2021
@teauxfu teauxfu changed the title remove dependency on pandas remove dependency on Pandas Jun 8, 2021
@teauxfu teauxfu changed the title remove dependency on Pandas clean up report exporting Jun 8, 2021
@teauxfu
Copy link
Member Author

teauxfu commented Oct 28, 2021

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Something could be handled better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@teauxfu