Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 202309 #83

Merged
merged 10 commits into from
Nov 22, 2023
Merged

support 202309 #83

merged 10 commits into from
Nov 22, 2023

Conversation

vegu
Copy link
Contributor

@vegu vegu commented Oct 19, 2023

  • refactor of sync and fetch logic to simplify and modernize approach
  • --fetch-private for sync command
  • fix cache url

@vegu vegu requested a review from grizz October 19, 2023 15:28
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (c16718a) 84.26% compared to head (e9c2c90) 82.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   84.26%   82.27%   -1.99%     
==========================================
  Files          18       16       -2     
  Lines        1258     1072     -186     
==========================================
- Hits         1060      882     -178     
+ Misses        198      190       -8     
Files Coverage Δ
src/peeringdb/__init__.py 88.09% <100.00%> (-2.39%) ⬇️
src/peeringdb/_sync.py 92.00% <100.00%> (+3.25%) ⬆️
src/peeringdb/cli.py 87.50% <100.00%> (-1.39%) ⬇️
src/peeringdb/client.py 97.43% <100.00%> (+1.35%) ⬆️
src/peeringdb/config.py 80.58% <100.00%> (ø)
src/peeringdb/output/_yaml.py 98.21% <100.00%> (+0.03%) ⬆️
src/peeringdb/resource.py 93.75% <ø> (ø)
src/peeringdb/util.py 56.75% <100.00%> (-0.58%) ⬇️
src/peeringdb/commands.py 84.02% <82.60%> (-2.21%) ⬇️
src/peeringdb/private.py 27.27% <27.27%> (ø)
... and 2 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

--fetch-private for sync
cache url fixes

linting

Co-authored-by: Nate Sales <[email protected]>
@vegu vegu merged commit a597426 into master Nov 22, 2023
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants