Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sites don't follow pattern #25

Open
nihaals opened this issue Sep 11, 2018 · 2 comments
Open

Sites don't follow pattern #25

nihaals opened this issue Sep 11, 2018 · 2 comments

Comments

@nihaals
Copy link
Contributor

nihaals commented Sep 11, 2018

Instead of storing the entire site e.g Discord, store just the invite code then add the URL when displaying it or have a script that imports the data and adds the URLs.

  • https://twitch.tv/$
  • https://discord.gg/$ - Some sites also use https://discordapp.com/invite/$ which is discouraged, however, d.gg invites redirect to this page, so could be better to use this instead. https://dis.gd/cohhcarnage is even used which isn't valid.
  • https://www.youtube.com/c/$
  • https://twitter.com/$
  • https://www.facebook.com/$
@pegasy
Copy link
Owner

pegasy commented Sep 12, 2018

That only works for some of them, like twitch, twitter and facebook.
Some people use stuff like discord.me for discord invites, as for youtube not everyone has a "channel" page.
Examples

This could be solved by saving it as user/lN00blShowtek or frozenballzgaming instead but then you might as well store the full url, I don't really see the benefit of saving only the name / type only vs the whole url.

@nihaals
Copy link
Contributor Author

nihaals commented Sep 12, 2018

It would mean that the URLs are consistent, you could still store the whole URL, however, you would still need to check that all the URLs match each other, as you shouldn't have different URLs for similar pages or pages that get redirected when you can just store the correct URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants