From aa5bfd4ccb23781d105b2629cf473fcf1da20fcd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20H=C3=A1la?= <halapetr@selfnet.cz>
Date: Tue, 26 Dec 2023 16:15:39 +0100
Subject: [PATCH] Rework song list page into bootstrap accordion

- Less code to maintain
- Improved visuals
- Scroll button is now only shown when the song is unwrapped
---
 backend/static/js/chords.js        |  5 -----
 backend/templates/songs/index.html | 25 ++++++++++++++++++-------
 frontend/static/styles.sass        | 15 ++++++++++++++-
 3 files changed, 32 insertions(+), 13 deletions(-)

diff --git a/backend/static/js/chords.js b/backend/static/js/chords.js
index 1b6125d..d3b5509 100644
--- a/backend/static/js/chords.js
+++ b/backend/static/js/chords.js
@@ -22,11 +22,6 @@ function transpose(event, object, id) {
     input.attr("previous_value", new_value);
 }
 
-function collapsible(element, id) {
-    $(".song:visible").not("#" + id).slideUp()
-    $('#' + id).slideToggle()
-}
-
 function isElementInViewPort(element) {
     let rect = element.getBoundingClientRect();
     // get the height of the window
diff --git a/backend/templates/songs/index.html b/backend/templates/songs/index.html
index 3901f57..12eaac6 100644
--- a/backend/templates/songs/index.html
+++ b/backend/templates/songs/index.html
@@ -32,9 +32,19 @@
 </div>
 {% endblock %}
 {% block body %}
+    <script async>
+        function show_scroll_button(event) {
+            const button = $("#scroll-down")
+            if (document.querySelector(".accordion-button:not(.collapsed)") !== null) {
+                button.show()
+                return
+            }
+            button.hide()
+        }
+    </script>
     <script id="songTemplate" type="text/x-jsrender">
-        <div class="collapsible-controller w-100 pb-1 ps-2 pt-2 border-bottom rounded"  onclick="collapsible(this,'<%:number%>')">
-            <h2 class="d-inline <%if archived%>text-danger<%/if%>"><span style="width: 50px;"><%:number%>.</span> <%:name%></h2>
+        <a class="accordion-button text-decoration-none w-100 border-bottom collapsed pt-2 pb-1" data-bs-toggle="collapse" href="#id<%:number%>" role="button" aria-controls="<%:number%>" aria-expanded="false" onclick="show_scroll_button(event)">
+            <h2 class="d-inline me-2 <%if archived%>text-danger<%/if%>"><span style="width: 50px;"><%:number%>.</span> <%:name%></h2>
             <%if author%>
                 <h6 class="d-inline" ><%:author%></h6>
             <%/if%>
@@ -52,8 +62,8 @@ <h6 class="d-inline" ><%:author%></h6>
                </form>
             {% endif %}
             </span>
-        </div>
-        <div id="<%:number%>" class="song" style="display: none;">
+        </a>
+        <div id="id<%:number%>" class="accordion-collapse collapse" data-bs-parent="#datatable">
             <div class="input-group mb-3">
                 <%if link%>
                     <a href="<%:link%>" class="btn btn-primary" role="button" aria-pressed="true">
@@ -79,14 +89,14 @@ <h6 class="d-inline" ><%:author%></h6>
         <input type="text" class="form-control" id="searchInput" placeholder="{% trans "Number, text or author" %}">
       </div>
     </div>
-    <table id="datatable" class="dataTable w-100 song-list table-borderless table-hover">
+    <table id="datatable" class="accordion accordion-flush w-100 table table-borderless">
         <thead class="d-none"></thead>
         <tbody class="w-100 m-0"></tbody>
     </table>
-    <button id="back-to-top" class="btn btn-info btn-lg back-to-top" role="button" title="Click to return on the top page" data-bs-toggle="tooltip" data-bs-placement="left">
+    <button id="back-to-top" class="btn btn-primary btn-lg back-to-top" role="button" title="Click to return on the top page" data-bs-toggle="tooltip" data-bs-placement="left">
         <span class="icon-up-open"></span>
     </button>
-    <button id="scroll-down" class="btn btn-info btn-lg scroll_button" role="button" title="Click to scroll down" data-bs-placement="left">
+    <button id="scroll-down" class="btn btn-primary btn-lg scroll_button" role="button" title="Click to scroll down" data-bs-placement="left">
         <span class="icon-down-open"></span>
     </button>
     <script type="module">
@@ -132,6 +142,7 @@ <h6 class="d-inline" ><%:author%></h6>
                     {% endif %}
                     return $.render.song(row);
                 },
+                className: "accordion-item mt-1 ms-1 p-0",
                 searchable: true,
             },
             {
diff --git a/frontend/static/styles.sass b/frontend/static/styles.sass
index cbac248..5374e8c 100644
--- a/frontend/static/styles.sass
+++ b/frontend/static/styles.sass
@@ -32,12 +32,15 @@ html, body
     top: 20px
     right: 20px
     display: none
+    z-index: 10
 
 .scroll_button
     cursor: pointer
     position: fixed
+    display: none
     bottom: 20px
     right: 20px
+    z-index: 10
 
 hr
   background-color: $border-color
@@ -66,4 +69,14 @@ hr
  color: $colDefault
 
 .small-hr
-  height: 1px
\ No newline at end of file
+  height: 1px
+
+.accordion-button:not(.collapsed)
+  background-color: white
+  color: black
+  &:focus
+    box-shadow: var(--bs-accordion-btn-focus-box-shadow)
+
+.accordion-button:focus
+  box-shadow: none
+