Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Amend PDM 007): Fix incorrect allowed-currency counting in currencies allowance pallet #297

Closed
ebma opened this issue Aug 15, 2023 · 0 comments · Fixed by #298
Closed

(Amend PDM 007): Fix incorrect allowed-currency counting in currencies allowance pallet #297

ebma opened this issue Aug 15, 2023 · 0 comments · Fixed by #298
Assignees
@ebma
Labels
type:bug Something isn't working

Comments

@ebma
Copy link
Member

ebma commented Aug 15, 2023 •
edited
Loading

There is a bug with our limitation of the size of the allowed currency vector. In this line, instead of using the length of the supplied vector again, we should instead compare it to the new length of the AllowedCurrencies storage item.
@ebma ebma self-assigned this Aug 15, 2023
@ebma ebma added the type:bug Something isn't working label Aug 15, 2023
@ebma ebma linked a pull request Aug 15, 2023 that will close this issue
Fix wrong allowed_currencies_len variable #298
Merged
@ebma ebma mentioned this issue Aug 15, 2023
Merged
@ebma ebma closed this as completed in #298 Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebma ebma

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wrong allowed_currencies_len variable pendulum-chain/pendulum
1 participant
@ebma