Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new rpc function of spacewalks oracle pallet for all runtimes #311

Conversation

gianfra-t
Copy link
Contributor

@gianfra-t gianfra-t commented Oct 3, 2023

Note: Requires merge spacewalk's PR #402, For now I will leave as draft to later point to the corresponding commit rev of spacewalk.

Implements the new RPC function to get exchange rates for Foucoco, Amplitude.
Pendulum runtime does not currently implements oracle pallet, this would be required first to implement the new RPC method.

Issue #286

This will require a node redeployment since runtime is modified.

@gianfra-t gianfra-t force-pushed the 286-implement-new-rpc-function-of-spacewalks-oracle-pallet-for-all-runtimes branch from 206b45c to 94385b6 Compare October 3, 2023 16:21
@ebma ebma marked this pull request as ready for review October 16, 2023 12:57
@ebma ebma self-requested a review October 16, 2023 12:57
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
I'll merge this now because the PR that originally blocked it was already merged and I added the same changes in this PR already (because I forgot that this one existed).

@ebma ebma merged commit 08b2eef into main Oct 16, 2023
2 checks passed
@ebma ebma deleted the 286-implement-new-rpc-function-of-spacewalks-oracle-pallet-for-all-runtimes branch October 16, 2023 12:58
@gianfra-t
Copy link
Contributor Author

Thanks, I wasn't aware that it got unblocked. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new RPC function of Spacewalk's 'oracle' pallet for all runtimes
2 participants