Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register Moonbase DEV on Moonbeam Foucoco testnet #367

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Register Moonbase DEV on Moonbeam Foucoco testnet #367

merged 5 commits into from
Dec 6, 2023

Conversation

bogdanS98
Copy link
Contributor

Closes #366.

@bogdanS98 bogdanS98 requested a review from ebma December 5, 2023 15:58
@bogdanS98 bogdanS98 linked an issue Dec 5, 2023 that may be closed by this pull request
Register Moonbase Alpha's DEV token on Foucoco #366
Closed
3 tasks
@ebma ebma requested a review from a team December 5, 2023 16:48
ebma
ebma requested changes Dec 5, 2023
View reviewed changes
runtime/foucoco/src/assets.rs Outdated Show resolved Hide resolved
runtime/foucoco/src/assets.rs Outdated Show resolved Hide resolved
@bogdanS98 bogdanS98 requested a review from ebma December 5, 2023 17:12
ebma
ebma approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

runtime/common/src/lib.rs Outdated Show resolved Hide resolved
runtime/foucoco/src/assets.rs Outdated Show resolved Hide resolved
ebma
ebma approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I think 👍

@bogdanS98 bogdanS98 merged commit 10f3b7f into main Dec 6, 2023
2 checks passed
@bogdanS98 bogdanS98 deleted the 366-register-moonbase-alphas-dev-token-on-foucoco branch December 6, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebma ebma ebma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Register Moonbase Alpha's DEV token on Foucoco
2 participants
@bogdanS98 @ebma