-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pindexer: implement override for hardcoded values in app views #4936
base: main
Are you sure you want to change the base?
Conversation
8d14969
to
f794074
Compare
I tried reindexing testnet chain data with args I'm certain there's liquidity there, because when I view my own LPs:
The dex explorer can display summaries for gm/gn just fine: Am I wrong to assume that using this PR would affect summaries in the dex explorer? Should I instead be trying with the insights app? |
hmm, I'm going to try this on my end as well ; a priori I'd expect it to start working 🤔 Checking insights would be good as well |
This looks backwards for the current price and liquidity, allowing us to handle cases where snapshots are sparse, like on the testnet.
I pushed a commit which fixed unrelated issues with the behavior of the summary tab for assets with infrequent trading. I don't think the dex explorer frontend has the relevant page where this overriden value matters, which is the "aggregate summary" page (where "explore" will point to) |
Describe your changes
This adds two flags:
for setting the denom used for indexing (instead of USDC)
and
for overriding the minimum liquidity in terms of that asset for a pair to be considered in the aggregate dex explorer summary.
Closes #4920.
For testing, we can try running this against the testnet with different values.
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: