Added pop column #103
Merged
Added pop column #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khoroshevskyi
force-pushed
the
24_pop
branch
from
7b82d74 to
439c78b
Compare
nleroy917
approved these changes
Dec 11, 2023
| @@ -315,6 +325,7 @@ def _overwrite( | |||
| private: bool = False, | |||
| pep_schema: str = None, | |||
| description: str = "", | |||
| pop: bool = False, | |||
There was a problem hiding this comment.
I'm trying to think of any consequences that might occur from us defaulting to False here, but I can't immediately think of any...
There was a problem hiding this comment.
I don't think it should cause any problems. pop is like private, but you can't change it. If you set it, it should be pop. So it's only metadata for pephub, nothing else. All the configurations will be then done in pephub (I am against this approach, but decision was made)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.