Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the views interface #370

Open
nsheff opened this issue Aug 14, 2024 · 2 comments
Open

Improving the views interface #370

nsheff opened this issue Aug 14, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request UI/UX
Milestone

Comments

@nsheff
Copy link
Contributor

nsheff commented Aug 14, 2024

Views suggestions

  1. The interface for adding a view right now is not explained anywhere, and is unintuitive. It could be either:

    • In the "Manage Views" modal, keep the "Save view" section (right now it is simply absent if there is no filter applied). If no filter is applied, then just show a brief explanation that says "No filter has been applied. To save a view, apply a filter using the column drop downs to select a subset of rows". This would go away if a filter has been applied. (preferred)
    • add a "Save View" button to the main interface; if it's clicked without a filter, pop up a modal explaining how the filter works (less preferred)
  2. For removing/selecting a view: I find it unintuitive that the Default is "No view", which you get by "Closing" the view. Instead, I find it more intuitive if the default is one of the view options. So, under "Select a view", I should be able to select "No view" or "Default view" or "Entire table", instead of having to click the "x" to "remove" the view.

  3. The tooltip is annoying me. it comes up literally every time I mouse over the views button. It also doesn't disappear when I click it. It should disappear when I click it. It should be triggered by a little "info/help" button" instead of a mouseover? I suggest we start to add little question marks with circles (?) and when you click that, you get a little explainer.

  4. Minor concern, but ideally, "Add View" and "Remove View" should be Tabs in the modal, rather than vertical

  5. Minor concern: There's no mechanism to edit the description of a view. Maybe this is for the future.

  6. It's strange to me that the view cannot be edited by the HandsOnTable interface.

  7. Right now, opening a view makes the table read-only. This doesn't make sense to me; the view should allow editing of a subset of the files. That is kind of the point, to allow us to see and interact with just a few of the samples.

@nsheff
Copy link
Contributor Author

nsheff commented Aug 14, 2024

On the tooltip: the schema one is better:
image

But even this one, if you click it, it should go away -- you shouldn't have to click the "I" button again.

@nsheff nsheff added this to the v0.13.1 milestone Aug 26, 2024
@sanghoonio
Copy link
Member

  1. Save view now shows in the modal at all times, but is disabled and shows a message if no filter is applied.
  2. Added a default view that acts as a placeholder for 'null' selected view, and removed the clearable 'x' button.
  3. Updated the hover timing of the tooltip so that for 4 times after hovering over the tooltip once, the tooltip requires you to hover for 1600ms rather than 200ms for it to show. As long as you don't park your cursor on the dropdown every time, the tooltip should not show every time.
  4. Modal updated to use tabs interface.

Remaining issues require rework of views and will take longer to implement.

sanghoonio added a commit that referenced this issue Aug 26, 2024
@sanghoonio sanghoonio added enhancement New feature or request and removed likely solved labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI/UX
Projects
None yet
Development

No branches or pull requests

2 participants