Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naming of optional dependency packages #129

Closed
nsheff opened this issue Dec 6, 2023 · 3 comments
Closed

naming of optional dependency packages #129

nsheff opened this issue Dec 6, 2023 · 3 comments

Comments

@nsheff
Copy link
Contributor

nsheff commented Dec 6, 2023

It bothers me a little that the backend optional dependency package is named db-backend, because python packages and modules can't have hyphens in them.

It works to have the hyphen in there, since this isn't a module or package... but still, it caused me some problems because when it wasn't working, I thought it might be due to that.

I think it would be better to have a one-to-one correspondence between optional dependency name and module name. Since we call the module dbbackend in the code, I think the optional dependency name should correspond, and be dbbackend.

what do you think?

@donaldcampbelljr
Copy link
Contributor

I implemented this change in dev last week:
81ca9f2

@nsheff
Copy link
Contributor Author

nsheff commented Dec 11, 2023

thanks.

@donaldcampbelljr
Copy link
Contributor

Closed via #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants