Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic menus have wrong classes #35

Open
1jerry opened this issue Sep 27, 2017 · 1 comment
Open

Semantic menus have wrong classes #35

1jerry opened this issue Sep 27, 2017 · 1 comment

Comments

@1jerry
Copy link

1jerry commented Sep 27, 2017

using example Invoices.
Main menus are using Bootstrap classes. Attached is a diff file that fixes that.

fix classes.diff.txt

@perak
Copy link
Owner

perak commented Sep 27, 2017

@1jerry thanks for reporting, but this is not a bug.

Classes are hard-coded into input file, see here:

https://github.com/perak/kitchen-examples/blob/master/example-invoices/example-invoices.json#L198

https://github.com/perak/kitchen-examples/blob/master/example-invoices/example-invoices.json#L208

etc.

But, I agree that examples should not have any frontend framework specific classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants