Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement default replace workflow #160

Open
beam-sysuser opened this issue Sep 13, 2019 · 4 comments
Open

Implement default replace workflow #160

beam-sysuser opened this issue Sep 13, 2019 · 4 comments

Comments

@beam-sysuser
Copy link

beam-sysuser commented Sep 13, 2019

Update: I think this should be part of a larger effort to implement a default replace workflow combined with the ability to detect when an update and replace affect the same resource and only do the replace.

STR:

  • Create a security group with tags.
  • Update both the security group name (requires a replace) and the tags (can be updated in-place)
  • gyro up
⇅ Replace aws::security-group backend/backend (sg-02762bd7db5859b3d) (because of description, name, skipping without a workflow)
· description:  'Limit backend traffic to OpenVPN/SSH' → 'beam-sandbox-production-backend-us-east-1-v1'
· name:  'beam-sandbox backend serial-1' → 'beam-sandbox-production-backend-us-east-1-v1'
· tags:  +{ Name: 'beam-sandbox production backend v1', beam.project: 'beam-sandbox', beam.serial: '1' }

.
.
.

⇅ Replacing aws::security-group backend/backend (sg-02762bd7db5859b3d)

· description:  'Limit backend traffic to OpenVPN/SSH' → 'beam-sandbox-production-backend-us-east-1-v1'

· name:  'beam-sandbox backend serial-1' → 'beam-sandbox-production-backend-us-east-1-v1'

· tags:  +{ Name: 'beam-sandbox production backend v1', beam.project: 'beam-sandbox', beam.serial: '1' }

SKIPPED
@beam-sysuser
Copy link
Author

#136

The current idea is to do as much as gyro can. Replace or update based on whether the resource is replaceable, if the resource is not replaceable, update the updatable fields instead.

by PSDHao

@beam-sysuser
Copy link
Author

Merged the wrong PR. This doesn't work anyway. Breaks our autoscaling workflow.

by beetlebugorg

@beam-sysuser
Copy link
Author

New branches:
https://github.com/perfectsense/gyro/tree/feature/replace-update
https://github.com/perfectsense/gyro-aws-provider/tree/feature/replace-update

After talking with Hyoo, the current idea is to create two changes (replace and update) when appropriate. The idea is subject to changes.

by PSDHao

@beam-sysuser
Copy link
Author

#142
After discussion, changed back to having a single change where having update logic within replace.

by PSDHao

@beam-sysuser beam-sysuser added this to the 0.99.1 milestone Oct 8, 2019
@beetlebugorg beetlebugorg modified the milestones: 0.99.1, 0.99.2 Jan 29, 2020
@beetlebugorg beetlebugorg changed the title Updates skipped if both a "Replace" and "Update" diff exist Implement default replace workflow Feb 12, 2020
@beetlebugorg beetlebugorg removed this from the 0.99.2 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants