Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gyro CLI always exits with '0' even if there's an error. #335

Open
sshyub opened this issue Dec 11, 2020 · 0 comments
Open

Gyro CLI always exits with '0' even if there's an error. #335

sshyub opened this issue Dec 11, 2020 · 0 comments

Comments

@sshyub
Copy link

sshyub commented Dec 11, 2020

Describe the bug
Gyro CLI always exits with '0' even if there's an error.

To Reproduce
Give a wrong credential file in init.gyro, and run gyro up.

Expected behavior
Gyro exited with '1' previously.

Additional context
After gyro cli refactored with picocli, exception is handled by
commandLine.setExecutionExceptionHandler(Gyro::invalidUserInput); in Gyro#init(), which always returns the status code, 2, but then it is even suppressed by Gyro#run().

Fixes should match the exit codes that are declared in the catch clauses in Gyro#main() function.
Also the catch clauses in main should be removed if they are not used any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant