Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saying N to wait directive doesn't permanently skip it. #364

Open
RichieHowell opened this issue Apr 27, 2021 · 1 comment
Open

Saying N to wait directive doesn't permanently skip it. #364

RichieHowell opened this issue Apr 27, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@RichieHowell
Copy link

Describe the bug
When you have a wait directive, you have the ability to say "n" to a wait to completion prompt. This skips the wait directive for the current run but if you have a second wait directive which you also say "n" to, the test for the first wait directive comes back.

To Reproduce
Create a workflow with 2 wait directives and a check which will always fail. Attempt to say "n" to the "wait for completion" prompt and it will start the second wait directive. Attempt to say "n" to this one, and it will begin the first one again.

Expected behavior
After saying n to a wait directive, it should respond as if the wait directive has passed tests.

Additional context
I have not tested this with small wait times, only with 2 wait directives with these settings

-check-every 10 -at-most 120

@RichieHowell
Copy link
Author

Further Context, in the below output you can see the cms verify was tested twice even though it was skipped.

            Wait for completion? (Y/n) n

        ⧖ Waiting for: $('aws::load-balancer-target-group' 'prod-cms-verify').'target-health'.'healthy' = $('desired-capacity')
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED

            Wait for completion? (Y/n) n

        ⧖ Waiting for: $('aws::load-balancer-target-group' 'prod-frontend-verify').'target-health'.'healthy' = $('desired-capacity')
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED

            Wait for completion? (Y/n) n

        ⧖ Waiting for: $('aws::load-balancer-target-group' 'prod-cms-verify').'target-health'.'healthy' = $('desired-capacity')
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED
            ✓ Checking FAILED

@deepanjan90 deepanjan90 added the bug Something isn't working label Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants