-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ao components ought to only dedupe ao Protocol specific tags and values #1059
Open
5 of 8 tasks
Comments
TillaTheHun0
added
bug
Something isn't working
cu
ao Compute Unit
su
ao Scheduler Unit
mu
ao Messenger unit
connect
ao connect
cli
ao CLI
scheduler-utils
Scheduler Utils
labels
Oct 29, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 29, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 30, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 30, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 30, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 30, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 31, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 31, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 31, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 31, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 31, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 31, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 31, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 31, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 31, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 31, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 31, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 31, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 31, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 31, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 31, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 31, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 31, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 31, 2024
TillaTheHun0
added a commit
that referenced
this issue
Oct 31, 2024
We've created a util that predictably implements this convention: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
Various ao components will deduplicate tags like
Type
andVariant
, that are outlined in the ao specification, to ensure ao protocol level tags are not duplicated.Problem
The deduping logic is too aggressive, and causes similarly named tags used by other protocols to be removed
Solution
ao components tag deduping logic needs to be reigned to only dedupe when both tag name and value conflict with an ao tag specification.
Developer Notes
Some components may not need any changes, but are listed here just to be comprehensive and for posterity.
aoconnect
mu
su
cu
dev cli
aos
Luaaos
CLIscheduler-utils
The text was updated successfully, but these errors were encountered: