Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow extra objects to be deployed alonside server and client #61

Open
gallolp opened this issue Aug 2, 2024 · 0 comments · May be fixed by #62
Open

Feature Request: Allow extra objects to be deployed alonside server and client #61

gallolp opened this issue Aug 2, 2024 · 0 comments · May be fixed by #62

Comments

@gallolp
Copy link

gallolp commented Aug 2, 2024

Hi,

I am currently working to deploy an OPAL server instance and an OPAL client instance (cluster mode) as separate releases using the Helm chart.

I see there is an undocumented secrets parameter on both server and client sections of the value file, however there is no way to deploy those secrets or any additional objects in the same release using the chart.

It would be great to be able to deploy extra manifests using the same chart, use cases include:

  • Private and Public keys as secrets (instead of regular env) when running in secure mode
  • Client token as secret
  • Broadcast url as secret (it contains the DB/Redis password)
  • Any other manifests ie. Istio manifests, etc

If you are interested, I have prepared a PR that adds the following:

  • A new extraObjects parameter to the root section of the value file
  • Updated values JSON schema (array of string)
  • Allows templates inside the objects, they are defined as strings to avoid yaml parse errors on the value file and allow templating
  • Adds sample values to the value file

Thank you for you work on OPAL.

Edited: Updated to only add one extraObjects section.

@gallolp gallolp linked a pull request Aug 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant