Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for the components #43

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Abiji-2020
Copy link
Contributor

@Abiji-2020 Abiji-2020 commented Nov 29, 2024

Unit test for the components

Currently Pending components

  • authCallbackServer in auth.js file
  • login and logout

Coverage report

image

/claim #12
closes #12

@Abiji-2020
Copy link
Contributor Author

Abiji-2020 commented Nov 29, 2024

@gemanor do we have to add unit test for the login component? As we are modifying the component itself in #13 and i see that the tests are included for them

@Abiji-2020 Abiji-2020 marked this pull request as ready for review November 29, 2024 16:08
@Abiji-2020
Copy link
Contributor Author

Abiji-2020 commented Nov 29, 2024

@quest-bot loot #12

@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Nov 29, 2024
Copy link

quest-bot bot commented Nov 29, 2024

Quest PR submitted! image Quest PR submitted!

@Abiji-2020, you are attempting to solve the issue and loot this Quest. Will you be successful?


Questions? Check out the docs.

@gemanor
Copy link
Collaborator

gemanor commented Nov 30, 2024

@Abiji-2020, yes, I would wait for #37 and then merge from main to ensure we have 90% coverage.
I'll let you know when mergin it.

@Abiji-2020
Copy link
Contributor Author

@Abiji-2020, yes, I would wait for #37 and then merge from main to ensure we have 90% coverage. I'll let you know when mergin it.

oh okayy,

@Abiji-2020
Copy link
Contributor Author

@gemanor any updates on #37

@gemanor
Copy link
Collaborator

gemanor commented Dec 11, 2024

No, we still waiting for Jay to submit the CR changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim ⚔️ Quest Tracks quest-bot quests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Proper Unit Test Coverage
2 participants