Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: move away from rebass and styled-components #51

Open
6 tasks
armand1m opened this issue Mar 11, 2019 · 1 comment
Open
6 tasks

Refactor: move away from rebass and styled-components #51

armand1m opened this issue Mar 11, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@armand1m
Copy link
Member

armand1m commented Mar 11, 2019

We are currently having problems integrating into our CI due to mismatches between preact API and a few dependencies we have.

Rebass used to work well with Preact before 3.x was released and made use of features like React.forwardRef which are not available in preact-compat.

Also, styled-components nowadays makes use of React.createContext, which is also not available in preact-compat.

(Even tho the preact team is working in Preact X, which will make this features available, is still in alpha stages and we cannot rely on it.)

So this issue aims to track the development of the few components the Perry Widget actually needs in order to work.

I suggest moving to https://github.com/emotion-js/emotion since it seems to use a more agnostic approach for CSS-in-JS.

Here is a checklist so we can track this better:

Primitives

  • <Modal />
  • <Button />
  • <Input />
  • <Label />
  • <LabeledInput />
  • <Form /> (I don't think we need something such as Formik for Perry)

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@armand1m armand1m added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 11, 2019
@armand1m
Copy link
Member Author

The UI is currently broken because we forced and removed those packages.

I will start working in these components today later.

@armand1m armand1m self-assigned this Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant