Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor persian_chars & remove_ordinal_suffix modules #52

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

thevilx
Copy link
Contributor

@thevilx thevilx commented Feb 3, 2024

persian_chars:

  • Removed 5 unused variables.

remove_ordinal_suffix:

  • Replaced if statements with else if statements to enhance matching speed.
  • Addressed an issue where the final if statement word.ends_with('م') was inadvertently capturing previous if statements such as ends_with("اُم"). The modification ensures more precise matching and avoids unintended captures.

@ali77gh ali77gh merged commit b699be7 into persian-tools:dev Feb 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants