Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to numpy 2.0 #1101

Open
raphaeltimbo opened this issue Aug 22, 2024 · 2 comments
Open

Upgrade to numpy 2.0 #1101

raphaeltimbo opened this issue Aug 22, 2024 · 2 comments
Labels
enhancement New feature or request stale Issues with no activity for a long period
Milestone

Comments

@raphaeltimbo
Copy link
Collaborator

We need to upgrade ross to work with numpy 2.0.
This means that we will have to change our test matrix so that we will only support python >= 3.9.

@raphaeltimbo raphaeltimbo added this to the 2.0.0 milestone Aug 22, 2024
@jguarato
Copy link
Contributor

For the record:

It appears that in NumPy 2.0.0, the representation repr of NumPy scalars changed, causing conflicts when running pytest.

See: NumPy 2.0.0 Release Notes

Possible solutions:

  1. Create a conftest.py file with a pytest hook to modify options for doctests:

    def pytest_configure(config):
        np.set_printoptions(legacy='1.25')

    This will ensure compatibility with the previous NumPy behavior.

  2. Update all doctests to align with the new NumPy behavior.

@ross-bott
Copy link
Collaborator

Hi there!
I have marked this issue as stale because it has not had activity for 45 days.
Consider the following options:

  • If the issue refers to a large task, break it in smaller issues that can be solved in
    less than 45 days;
  • Label the issue as wontfix or wontfix for now and close it.

@ross-bott ross-bott added the stale Issues with no activity for a long period label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Issues with no activity for a long period
Projects
None yet
Development

No branches or pull requests

4 participants