Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demos #11

Open
cvvergara opened this issue Sep 14, 2017 · 3 comments
Open

Demos #11

cvvergara opened this issue Sep 14, 2017 · 3 comments

Comments

@cvvergara
Copy link
Member

There are some "Demo" subdirectories
https://github.com/pgRouting/pgrouting/tree/master/src/contraction/demo
https://github.com/pgRouting/pgrouting/tree/master/src/dijkstra/demo
https://github.com/pgRouting/pgrouting/blob/master/src/max_flow/demo/slide_demo.sql

I declare my self guilty by making the first one in dijkstra :(

Now I want to remove those "demo",
They add nothing valuable to the repository:

  • They are incomplete (don't show results)
  • They are not documentation tests, or pgtap tests

maybe in a wiki or in a blog they would be better placed.

Now that the src/<subdir> only have src, those subdirectories are on the way for the restructuring
So, I will delete them in 2.6, and while developing 2.6 maybe a pgRouting blog could be useful to place them.
(with results, nice comments, etc)

@dkastl
Copy link
Member

dkastl commented Sep 15, 2017

Sounds reasonable to remove the demos. Since I even didn't know about them, I wouldn't have missed them anyway ;-)

To me "demo" looks a bit like "documentation example".
If there are demos, that would be nice to keep, maybe they could fit into the workshop, too.

@cvvergara
Copy link
Member Author

We can use the "google code in" to have some students add those examples to the workshop.
Could be classified as documentation/training.

@cvvergara
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants