Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed version check for pgRouting v3 support #128

Merged
merged 4 commits into from
Oct 9, 2020

Conversation

cayetanobv
Copy link
Member

Fixes #126 .

Changes proposed in this pull request:

  • fixed pgr_version check for v3
  • updated docs

@pgRouting/admins

@cayetanobv cayetanobv changed the title Fixe version check for pgRouting v3 support Fixed version check for pgRouting v3 support Apr 14, 2020
@cayetanobv cayetanobv added this to the Release 3.0.0 milestone Apr 14, 2020
@agiudiceandrea
Copy link

Hi @cayetanobv, did you forget to merge these commits?

@cayetanobv
Copy link
Member Author

Thanks @agiudiceandrea
Yes, I forgot to merge because v3 was released after this change.

@cayetanobv
Copy link
Member Author

@dkastl @cvvergara I think we can merge this PR. Culd you approve PR?

@agiudiceandrea
Copy link

Hi @cayetanobv,

in https://github.com/pgRouting/pgRoutingLayer/blob/master/README.md is stated that:

Dependencies
pgRouting v2.x up and running to use this plugin.

So, this should be changed to pgRouting v3.x, isn't it?

It is also stated that:

Additionally, QGIS needs python-psycopg2 installed to be able to connect to the database.

Is python-psycopg2 yet needed? Or is python3-psycopg2 needed instead?

@cayetanobv
Copy link
Member Author

yes, you are right @agiudiceandrea . Docs should be fixed. Could you update this versions and push it with this PR so we can merge all together?

@cayetanobv
Copy link
Member Author

Thanks @agiudiceandrea

@cayetanobv cayetanobv merged commit 5c586c1 into develop Oct 9, 2020
@cayetanobv
Copy link
Member Author

cayetanobv commented Oct 9, 2020

Sorry @agiudiceandrea but I didn't notice that you are pushing to my branch and you haven't permissions so your code wasn't merged. Could you open a new branch with these changes and open a new PR? After that, I can merge your changes.
Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants