set end_stream=True when sending trailers #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation in #254
If the approach is approved (I assume details might be wrong) then I'll gladly add some tests to prevent regressions.
I ran tox and only mypy seems to be failing.
I tested manually with some grpc clients and they show the response properly (I tested unary and streaming responses and it looks good)
Not sure how to handle it with more_trailers=True, but I don't understand how it's supposed to work in general since http2 requires END_STREAM being set for trailers frame (I assume that more_trailers implies a new frame, but maybe not?)