pgmoneta_ext_promote()

[jesperpedersen]

Add a function that basically calls

SELECT * FROM pg_promote()

-- requires SUPERUSER -- and return the true/false value

[jesperpedersen]

@GuChad369 Can you take this one ?

[jesperpedersen]

• https://www.postgresql.org/docs/17/spi.html
• https://www.postgresql.org/docs/17/spi-examples.html

[jesperpedersen]

Any way to do it is ok

[GuChad369]

sure

[GuChad369]

The pg_promote() function can only be executed when the server is in recovery mode. Do we need to verify if the server is in recovery mode and return an appropriate message if it is not.

[jesperpedersen]

Yes, you can do that -- a simple bool back and forth is ok

[jesperpedersen]

I mean, the message can be displayed in the client calling the function

[GuChad369]

In PostgreSQL, a warning message is already displayed if the server is not in recovery mode. Below is an example of a custom extension function call and its direct output.

postgres=# SELECT pgmoneta_ext_promote();
ERROR:  recovery is not in progress
HINT:  Recovery control functions can only be executed during recovery.
postgres=# SELECT * FROM pg_promote();
ERROR:  recovery is not in progress
HINT:  Recovery control functions can only be executed during recovery.

[jesperpedersen]

Yeah, that is enough for debugging - the client for the extension just need to know false or true