Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some of the last users of SystemAnnouncer uniqueInstance #17372

Merged
merged 2 commits into from
Nov 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OpalCompiler-Core/OpalCompiler.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ OpalCompiler >> evaluate [
ast ifNil: [ ^ doItMethod ].
value := self semanticScope evaluateDoIt: doItMethod.

self logged == true ifTrue: [ self semanticScope announceDoItEvaluation: source by: SystemAnnouncer uniqueInstance ].
self logged == true ifTrue: [ self semanticScope announceDoItEvaluation: source by: self class codeSupportAnnouncer ].
^ value
]

Expand Down
2 changes: 1 addition & 1 deletion src/OpalCompiler-Tests/OCArrayLiteralTest.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Class {
{ #category : 'running' }
OCArrayLiteralTest >> runCase [

SystemAnnouncer uniqueInstance suspendAllWhile: [ super runCase ]
self class codeChangeAnnouncer suspendAllWhile: [ super runCase ]
]

{ #category : 'running' }
Expand Down
3 changes: 2 additions & 1 deletion src/OpalCompiler-Tests/OCCompilerTest.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ OCCompilerTest >> notify: aString at: aSmallInteger in: aReadStream [

{ #category : 'running' }
OCCompilerTest >> runCase [
SystemAnnouncer uniqueInstance suspendAllWhile: [ super runCase ]

self class codeChangeAnnouncer suspendAllWhile: [ super runCase ]
]

{ #category : 'running' }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@ RBRefactoringChangeTest >> exampleTraits [
RBRefactoringChangeTest >> performAndUndoChange: aChange do: aBlock [
"Perform a change in the system silently, evaluate aBlock and then undo the change again."

| undo |
^ SystemAnnouncer uniqueInstance suspendAllWhile: [
undo := aChange execute.
aBlock ensure: [ undo execute ] ]
^ self class codeChangeAnnouncer suspendAllWhile: [
| undo |
undo := aChange execute.
aBlock ensure: [ undo execute ] ]
]

{ #category : 'mocking' }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ RBAbstractTransformationTest >> parserClass [
RBAbstractTransformationTest >> performAndUndoChange: aChange do: aBlock [
"Perform a change in the system silently, evaluate aBlock and then undo the change again."

| undo |
^ SystemAnnouncer uniqueInstance suspendAllWhile: [
undo := aChange execute.
aBlock ensure: [ undo execute ] ]
^ self class codeChangeAnnouncer suspendAllWhile: [
| undo |
undo := aChange execute.
aBlock ensure: [ undo execute ] ]
]

{ #category : 'running' }
Expand Down
1 change: 0 additions & 1 deletion src/Rubric/RubTextEditor.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -1661,7 +1661,6 @@ RubTextEditor >> nextWord: position [
Position N + 1 is after the Nth character"
initialPosition := 1 max: position.
index := initialPosition.
position traceCr.

string := self string.
size := string size + 1.
Expand Down