Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint:analyze suppressed based on theme exemptions for eslint:validate #215

Open
grayside opened this issue Dec 2, 2015 · 1 comment
Open

Comments

@grayside
Copy link
Contributor

grayside commented Dec 2, 2015

eslint:validate and eslint:analyze can target different files per the theme exemption provided by configuring Gruntconfig.json with the respective script, but only the validate tasks files mask is checked to determine if eslint should be configured at all for Grunt Drupal Tasks.

Instead, if either mask is successful eslint should be configured for the appropriate operation.

For bonus points, larger codebases will find the extra run of the file expansion to be moderately costly in performance, but the analyze task is not automatically triggered by the build like validate. As such, we can adjust how we define analyze to only run the file match if the grunt analyze task was run. This will minimize the impact of the analyze processing on other grunt jobs, including the main build process and grunt help.

@grayside grayside changed the title eslint:analyze suppressed based on theme exemptions for eslint:validate eslint:analyze suppressed based on theme exemptions for eslint:validate Dec 2, 2015
@grayside
Copy link
Contributor Author

grayside commented Dec 2, 2015

This was uncovered as part of the work done in #214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant