Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: CSS watch scripts failing in dev mode #405

Open
himerus opened this issue Jul 7, 2023 · 1 comment
Open

[Bug]: CSS watch scripts failing in dev mode #405

himerus opened this issue Jul 7, 2023 · 1 comment
Labels
Difficulty: Low Good First Issue A ticket/issue that should likely be an easy one for newcomers to the project/community. READY TO CODE This means a ticket is ready to be worked. Any ticket without this label should be verified. Type: Bug

Comments

@himerus
Copy link
Contributor

himerus commented Jul 7, 2023

Describe the bug
CSS IS NOT being auto reloaded/watched properly in dev mode.

To Reproduce
Steps to reproduce the behavior:

  • Make a change CSS or TS file related
  • Observe there is no change in Storybook
  • Stop the build.
  • Run yarn start

Expected behavior
CSS IS being auto reloaded/watched properly in dev mode.

Additional context
How to fix this:

In https://github.com/phase2/outline/blob/next/packages/outline-templates/default/scripts/styles.mjs#L180C1-L199, these lines ARE already uncommented, so this is appropriate.

in https://github.com/phase2/outline/blob/next/packages/outline-templates/default/package.json, we need to make it look more like this as seen here (for those with access):

image

Note the following changes.

"scripts": {
    "start": "yarn watch",
    "watch": "npm-run-all -p watch:*",
    "watch:storybook": "yarn storybook:dev",
    "watch:css": "node scripts/styles.mjs --watch"
  },
@himerus himerus added Type: Bug Difficulty: Low Good First Issue A ticket/issue that should likely be an easy one for newcomers to the project/community. READY TO CODE This means a ticket is ready to be worked. Any ticket without this label should be verified. labels Jul 7, 2023
@himerus
Copy link
Contributor Author

himerus commented Jul 7, 2023

Fix found here (with access)

in styles.mjs:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: Low Good First Issue A ticket/issue that should likely be an easy one for newcomers to the project/community. READY TO CODE This means a ticket is ready to be worked. Any ticket without this label should be verified. Type: Bug
Projects
None yet
Development

No branches or pull requests

1 participant