-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10.8 #955
base: main
Are you sure you want to change the base?
10.8 #955
Changes from all commits
2baa8c0
bf58e55
343905b
3773419
6cd1493
c5dc9b8
1291b7c
1ba2481
60e1fc4
4dded94
735eda6
855d0a6
49a5f60
5da035e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1 @@ | ||
last 2 versions | ||
not dead | ||
> 1% in US | ||
ie 11 | ||
defaults |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
hooks: | ||
pre-commit: "pretty-quick --staged" | ||
pre-commit: "pretty-quick --staged && npm run lint && npm test" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,4 @@ | ||
module.exports = { | ||
plugins: ['./node_modules/prettier-plugin-twig-melody'], | ||
proseWrap: 'always', | ||
singleQuote: true, | ||
twigAlwaysBreakObjects: true, | ||
twigOutputEndblockName: true, | ||
twigPrintWidth: 120, | ||
}; |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,31 +3,23 @@ | |
*/ | ||
|
||
const path = require('path'); | ||
const { DefinePlugin } = require('webpack'); | ||
|
||
// Plugins | ||
const RunScriptAfterEmit = require('../../tools/webpack/run-script-after-emit'); | ||
const particle = require('../../particle'); | ||
|
||
// Constants: environment | ||
const { NODE_ENV } = process.env; | ||
|
||
// Constants: root | ||
const { ASSETS_ATOMIC_FOLDER } = require('../../particle.root.config'); | ||
const { DefinePlugin } = require('webpack'); | ||
const { merge } = require('webpack-merge'); | ||
|
||
// Constants: app | ||
const appConfig = require('./particle.app.config'); | ||
// Get design system config | ||
const dsWebpackConfig = require('../../source/default/webpack.config'); | ||
|
||
const { APP_NAME, APP_DESIGN_SYSTEM, APP_DIST, APP_DIST_PUBLIC } = appConfig; | ||
const APP_NAME = 'app-drupal'; | ||
|
||
const shared = { | ||
const drupalWebpackConfig = { | ||
entry: { | ||
'drupal-jquery': [path.resolve(__dirname, 'drupal-jquery.js')], | ||
app: [path.resolve(__dirname, 'index.js')], | ||
}, | ||
output: { | ||
path: APP_DIST, | ||
publicPath: APP_DIST_PUBLIC, | ||
// Output all CSS/JS/images/twig to dist/ within drupal theme | ||
path: path.resolve(__dirname, 'particle_theme/dist'), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Octane programmatically moves this directory. |
||
}, | ||
module: { | ||
rules: [ | ||
|
@@ -36,8 +28,8 @@ const shared = { | |
loader: 'file-loader', | ||
options: { | ||
name: '[path][name].[ext]', | ||
outputPath: ASSETS_ATOMIC_FOLDER, | ||
context: APP_DESIGN_SYSTEM, | ||
outputPath: 'atomic/', | ||
context: path.resolve(__dirname, '../../source/default/'), | ||
emit: true, | ||
}, | ||
}, | ||
|
@@ -48,44 +40,13 @@ const shared = { | |
BUILD_TARGET: JSON.stringify(APP_NAME), | ||
}), | ||
], | ||
}; | ||
|
||
const dev = { | ||
stats: { | ||
children: false, | ||
entrypoints: false, | ||
}, | ||
plugins: [ | ||
new RunScriptAfterEmit({ | ||
exec: [ | ||
// prettier-ignore | ||
`echo \n🚀 Webpack Drupal ${NODE_ENV} build complete! Edit | ||
apps/drupal-default/webpack.config.js to replace this line with | ||
anything you'd like run after rebuilding assets, e.g. | ||
'drupal cr all'. 🚀\n`, | ||
], | ||
}), | ||
], | ||
externals: { | ||
jquery: 'jQuery', | ||
}, | ||
}; | ||
|
||
const prod = { | ||
stats: { | ||
children: false, | ||
entrypoints: false, | ||
chunks: false, | ||
}, | ||
}; | ||
|
||
module.exports = particle( | ||
// app: webpack | ||
{ shared, dev, prod }, | ||
// app: config | ||
appConfig, | ||
// Use extract css | ||
{ | ||
cssMode: 'extract', | ||
} | ||
); | ||
module.exports = merge(dsWebpackConfig, drupalWebpackConfig); |
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,5 @@ | |
<!-- End Pattern Lab --> | ||
|
||
</head> | ||
|
||
<body class="{{ bodyClass }}"> | ||
|
||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
|
||
<!--DO NOT REMOVE--> | ||
{{{ patternLabFoot }}} | ||
|
||
|
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional?