Skip to content
This repository has been archived by the owner on Aug 8, 2024. It is now read-only.

Defunct "Blog" view #105

Closed
TravisCarden opened this issue Jun 20, 2024 · 7 comments
Closed

Defunct "Blog" view #105

TravisCarden opened this issue Jun 20, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@TravisCarden
Copy link
Collaborator

There's a "Blog" view at /blog that, as far as I can tell, is defunct. If so, let's delete it.

@TravisCarden TravisCarden added the bug Something isn't working label Jun 20, 2024
@TravisCarden TravisCarden changed the title Defunt "Blog" view Defunct "Blog" view Jun 20, 2024
@phenaproxima
Copy link
Owner

Recipes cannot delete anything, but we could disable the view by setting its status to false.

@TravisCarden
Copy link
Collaborator Author

Then I propose we disable it. It's actually having (what I assume is) an unintended effect in that it's getting detected and inserted into the breadcrumb on blog post nodes, c.f. related #133.

@phenaproxima
Copy link
Owner

What if we went the opposite way, and embraced this view, with hackable URLs, for an automatic blog archive functionality?

@TravisCarden
Copy link
Collaborator Author

I can get onboard with that, as long as it's not incompatible with the whole goal of recipes being installable on an existing site, such that updating this view would potentially break existing functionality for users who are actually using it.

@phenaproxima
Copy link
Owner

For now, if the blog view is on an existing site, it would conflict. This is largely because we don't have config actions for views yet (and creating those will be a bear because views are...complicated, at best).

That said, I don't know if any (or even all) Starshot recipes are idempotent. Worth testing separately, but I'm not sure that should block this, since the prototype is meant as a starting point anyway.

@TravisCarden
Copy link
Collaborator Author

True. Seems like a detail that could easily be changed later. I say "go". 🙂

@phenaproxima
Copy link
Owner

Closing based on #133 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants