Skip to content
This repository has been archived by the owner on Aug 8, 2024. It is now read-only.

A few anomalies after switching from Gin and Navigation to Claro and Admin Toolbar #154

Open
gitressa opened this issue Jul 31, 2024 · 6 comments

Comments

@gitressa
Copy link
Contributor

The current combination is Gin and Navigation, but I prefer Claro and Admin Toolbar, which could be the most common combination. I just tried it, and found these anomalies:

  1. Headers are shown under Admin Toolbar
  2. "Announcements" is included in the menu
  3. "Configuration" menu item has been moved a few steps to the right (lower)

Starshot-Claro-Admin-Toolbar-headers-shown

@phenaproxima
Copy link
Owner

Can you reproduce this with plain core? If so, this isn't in Starshot's scope...it doesn't look, on its face, like a bug in the prototype, but if you can't reproduce it with core I'm happy to look into it further.

@gitressa
Copy link
Contributor Author

Thanks for a fast reply. I tried installing Drupal 10, enabling Gin and Navigation, and then uninstalling and replacing them with Claro and Admin Toolbar, and everything works as expected.

I then tried the same with a fresh Starshot install, and the bug was replicated. Here are the steps for faster replication:

  • drush config:set system.theme admin claro -y
  • composer require drupal/admin_toolbar
  • drush in admin_toolbar admin_toolbar_tools admin_toolbar_search
  • drush un navigation
  • drush cache:rebuild

@phenaproxima
Copy link
Owner

phenaproxima commented Jul 31, 2024

Interesting - thanks for the clear steps to reproduce! That's quite curious indeed.

@gitressa
Copy link
Contributor Author

You're welcome! Did you see the same behaviour?

@phenaproxima
Copy link
Owner

drush config:set system.theme admin claro -y

@gitressa, question: did you run drush then claro (or otherwise install Claro at /admin/appearance) before this?

@gitressa
Copy link
Contributor Author

gitressa commented Aug 3, 2024

I did not run that command, and if you check under /admin/appearance, Claro is listed under "Installed themes", in a fresh Starshot install.

I simply install Starshot, and run those five Drush commands.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants