New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use a higher order polynomial for sawtooth DPW #124

Open

philburk opened this issue Apr 4, 2024 · 0 comments

Assignees

Labels

Owner

philburk commented Apr 4, 2024

Based on a more recent paper by Vesa Välimäki, the SawtoothOscillatorDPW algorithm could be improved.

https://mac.kaist.ac.kr/pubs/ValimakiNamSmithAbel-taslp2010.pdf

Use a 4th order polynomial.
Checked the scale factor. May be off by 2.
Check continuity around VERY_LOW_FREQUENCY.
Code could be refactored to only calculate diffed inside the conditional.
Comment styles are inconsistent, "/**/" vs "//".

https://github.com/philburk/jsyn/blob/master/src/main/java/com/jsyn/unitgen/SawtoothOscillatorDPW.java

philburk self-assigned this

philburk added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment