-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use gradle / add to artifactory #49
Comments
I'm glad you like JSyn. I want to make it useful for people. Different people need different things. So I have not yet tried to optimize the build for specific targets. I'm not opposed to it. It just hasn't been a priority. You're the first person to ask.
Does the JAR cause technical problems? It is handy for me to publish one JAR on the website.
Was there a specific build problem with JPortAudioDevice? JSyn also has over a hundred unit generators and you probably only use a few. The JavaSound code is also not used on Android. ProGuard should strip out unused code.
I want to understand. Are you proposing 3 git repositories or are the artifacts just gradle build targets? |
JARs have the following problems:
Regarding the split - I would suggest to do a multi-module gradle build: https://jitpack.io/docs/BUILDING/#multi-module-projects |
I want to consume this library in one android-application - looks really useful and seems to work nice - but currently I would have to drop in the jar which I do not find appealing. My solution now is to use @jitpack which points to a fork of jsyn where I added gradle build-files:
ligi/MassiveSignal@de89817
https://github.com/ligi/jsyn
also there I removed JPortAudioDevice and the corresponding dependency as I do not want this on android. Ideally I would see 3 artifacts here jsyn-core, then jsyn-android ( depends on core ) and jsyn-portaudio ( also depends on core ).
Not sure what your take on this is - could also provide a PR in this direction but would like to know your opinion on this before. Do you want to keep ant? What do you think about splitting into 3 artifacts?
cc @ptrv
The text was updated successfully, but these errors were encountered: