Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Imagick method synopses (#4118) #4120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stefanfisk
Copy link

The argument names were wrong for a lot of methods.

I'm not entirely sure that I know what I'm doing, but the steps I took were:

  1. Clone php/doc-en, php/doc-base, php/php-src and Imagick/imagick
  2. Manually fix the stub signature for Imagick::newImage() like in Fix nullable in Imagick.stub.php Imagick/imagick#674
  3. ./php-src/build/gen_stub.php --replace-methodsynopses ./imagick/*.stub.php ./doc-en/reference/imagick/

Resolves #4118.

The argument names where wrong for a lot of methods.
@stefanfisk
Copy link
Author

I also had to do some manual cleanup of trailing white space.

@Girgias
Copy link
Member

Girgias commented Nov 22, 2024

Could you maybe do this class by class in different PRs? As the stub changes currently also impacts how Xincludes are down in the class synopsis, so you probably need to also run ./php-src/build/gen_stub.php --replace-classsynopses ./imagick/*.stub.php ./doc-en/reference/imagick/ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The argument names for various Imagick methods are incorrect
2 participants