ext/bcmath: Correctly modified an existing document #4163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SakiTakamachi
force-pushed
the
bcmath/errors
branch
from
7416fdc
to
d0aea10
Compare
Girgias
requested changes
Nov 27, 2024
reference/bc/functions/bcmul.xml
Outdated
Comment on lines
55
to
64
| <refsect1 role="errors"> | ||
| &reftitle.errors; | ||
| <para> | ||
| This function throws a <exceptionname>ValueError</exceptionname> in the following cases: | ||
| <simplelist> | ||
| <member><parameter>num1</parameter> or <parameter>num2</parameter> is not a well-formed BCMath numeric string</member> | ||
| <member><parameter>scale</parameter> is outside the valid range</member> | ||
| </simplelist> | ||
| </para> | ||
| </refsect1> |
There was a problem hiding this comment.
Considering how often this is repeated I would use XIncludes to avoid the repetition
|
fixed |
|
@SakiTakamachi I pushed a bunch of wording fixes and docs fixes which are existing issues, as I wanted to check locally that everything renders somewhat as expected. |
nielsdos
approved these changes
Nov 30, 2024
| <simplelist> | ||
| <member> | ||
| <parameter>num1</parameter> or <parameter>num2</parameter> | ||
| is not a well-formed BCMath numeric string |
There was a problem hiding this comment.
Suggested change
| is not a well-formed BCMath numeric string | |
| is not a well-formed BCMath numeric string. |
| is not a well-formed BCMath numeric string | ||
| </member> | ||
| <member> | ||
| <parameter>scale</parameter> is outside the valid range |
There was a problem hiding this comment.
Suggested change
| <parameter>scale</parameter> is outside the valid range | |
| <parameter>scale</parameter> is outside the valid range. |
| <para> | ||
| This function throws a <exceptionname>ValueError</exceptionname> in the following cases: | ||
| <simplelist> | ||
| <member><parameter>num</parameter> is not a well-formed BCMath numeric string</member> |
There was a problem hiding this comment.
Suggested change
| <member><parameter>num</parameter> is not a well-formed BCMath numeric string</member> | |
| <member><parameter>num</parameter> is not a well-formed BCMath numeric string.</member> |
| This function throws a <exceptionname>ValueError</exceptionname> in the following cases: | ||
| <simplelist> | ||
| <member><parameter>num</parameter> is not a well-formed BCMath numeric string</member> | ||
| <member><parameter>scale</parameter> is outside the valid range</member> |
There was a problem hiding this comment.
Suggested change
| <member><parameter>scale</parameter> is outside the valid range</member> | |
| <member><parameter>scale</parameter> is outside the valid range.</member> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed and added exception behavior.
Also added a
<literal>tag.