From 9fc45e69737fcb0ce0960135302060d516003cdc Mon Sep 17 00:00:00 2001 From: Matt Friedman Date: Mon, 24 Jun 2024 10:03:39 -0700 Subject: [PATCH 1/2] Use less of the word subscribe in the UX Signed-off-by: Matt Friedman fix Signed-off-by: Matt Friedman --- language/en/webpushnotifications_module_acp.php | 6 +++--- language/en/webpushnotifications_module_ucp.php | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/language/en/webpushnotifications_module_acp.php b/language/en/webpushnotifications_module_acp.php index 37556c8..1977095 100644 --- a/language/en/webpushnotifications_module_acp.php +++ b/language/en/webpushnotifications_module_acp.php @@ -47,8 +47,8 @@ 'WEBPUSH_VAPID_PRIVATE' => 'Server identification private key', 'WEBPUSH_VAPID_PRIVATE_EXPLAIN' => 'The Voluntary Application Server Identification (VAPID) private key is used to generate authenticated push messages dispatched from your site. The VAPID private key must form a valid public-private key pair alongside the VAPID public key.
Caution: Modifying the VAPID private key will automatically render all Web Push subscriptions invalid.', 'WEBPUSH_METHOD_ENABLED' => 'Enable user-based web push notifications by default', - 'WEBPUSH_METHOD_ENABLED_EXPLAIN'=> 'When this setting is enabled, users who subscribe and allow browser notifications will start receiving them automatically. They only need to visit the UCP Notification settings to disable any unwanted notifications.

If this setting is disabled, users will not receive any notifications, even if they have subscribed, until they visit the UCP Notification settings to enable the specific notifications they wish to receive.', - 'WEBPUSH_DROPDOWN_SUBSCRIBE' => 'Show “Subscribe” button in notification dropdown', - 'WEBPUSH_DROPDOWN_SUBSCRIBE_EXPLAIN'=> 'Enable or disable the “Subscribe” button in the Notification dropdown, allowing users to easily subscribe to push notifications from any page of the forum.', + 'WEBPUSH_METHOD_ENABLED_EXPLAIN'=> 'When this setting is enabled, users who have also enabled and allowed browser notifications will start receiving them automatically. They can visit the UCP Notification settings to disable any unwanted notifications.

If this setting is disabled, users will not receive any notifications, even if they have enabled push notifications, until they visit the UCP Notification settings to allow the specific notifications they wish to receive.', + 'WEBPUSH_DROPDOWN_SUBSCRIBE' => 'Show web push settings in the notification dropdown', + 'WEBPUSH_DROPDOWN_SUBSCRIBE_EXPLAIN'=> 'Show or hide the “Enable Web Push” toggle switch in the notification dropdown. This allows users to easily enable or disable push notifications from any page of the forum.', 'WEBPUSH_INSECURE_SERVER_ERROR' => 'This board is not using a secure SSL/HTTPS server protocol, which is required to enable and use web push notifications.', ]); diff --git a/language/en/webpushnotifications_module_ucp.php b/language/en/webpushnotifications_module_ucp.php index f4056a9..7fecabc 100644 --- a/language/en/webpushnotifications_module_ucp.php +++ b/language/en/webpushnotifications_module_ucp.php @@ -43,8 +43,8 @@ 'NOTIFY_WEBPUSH_DISABLE' => 'Disable Push Notifications', 'NOTIFY_WEBPUSH_ENABLE' => 'Enable Push Notifications', 'NOTIFY_WEBPUSH_ENABLE_EXPLAIN' => 'Enabling push notifications will activate them on this device only. You can turn off notifications at any time through your browser settings or by clicking the button above. Additionally, if no web push notification types are selected below, you will not receive any web push notifications.', - 'NOTIFY_WEBPUSH_SUBSCRIBE' => 'Subscribe', - 'NOTIFY_WEBPUSH_UNSUBSCRIBE' => 'Unsubscribe', + 'NOTIFY_WEBPUSH_SUBSCRIBE' => 'Enable to subscribe', + 'NOTIFY_WEBPUSH_UNSUBSCRIBE' => 'Disable to unsubscribe', 'NOTIFY_WEBPUSH_DROPDOWN_TITLE' => 'Visit notifications settings to set your preferred push notifications.', - 'NOTIFY_WEBPUSH_DENIED' => 'You have denied notifications from this site. To subscribe, please allow notifications in your browser settings.', + 'NOTIFY_WEBPUSH_DENIED' => 'You have denied notifications from this site. To enable push notifications, allow notifications from this site in your browser settings.', ]); From d4886be25bf7e5d765b96999d18e785c411cb706 Mon Sep 17 00:00:00 2001 From: Matt Friedman Date: Mon, 24 Jun 2024 10:03:59 -0700 Subject: [PATCH 2/2] Remove deprecated media queries Signed-off-by: Matt Friedman --- styles/all/theme/phpbb_wpn.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/styles/all/theme/phpbb_wpn.css b/styles/all/theme/phpbb_wpn.css index 743fe4f..415d0b2 100644 --- a/styles/all/theme/phpbb_wpn.css +++ b/styles/all/theme/phpbb_wpn.css @@ -40,13 +40,13 @@ font-size: 20px; } -@media only screen and (max-width: 350px), only screen and (max-device-width: 350px) { +@media (max-width: 350px) { .wpn-notification-dropdown-footer button > .icon { font-size: 24px; } } -@media only screen and (max-width: 700px), only screen and (max-device-width: 700px) { +@media (max-width: 700px) { .wpn.button { margin-top: 8px; }