bug fixes (#12), Gemfile grouping, subdir feature (#13) and css cleanup #47
Conversation
stbuehler
commented
Aug 17, 2013
stbuehler
commented
- Update cancan, fixing Comment.accessible_by (fixes Comment.accessible_by broken #12)
- Group database adaptors mysql/postgresql/sqlite
- fix path handling for subdir mounting (fixes Juvia not working properly when deployed to a sub URI #13)
- css fixes: typo, duplicates, pre/code should be visible in preview too, remove font for comments
- the comments should use the same font as the page they are embedded in
|
Sorry for taking so long to reply. Does this pull request obsolete issue #13? |
|
Yes, the commit with |
|
It looks like I don't have enough time to get this merged in the short term. I'm preparing a conference trip and I'll be away for a week. I'll have a better look when I'm back. |
|
Back to work? http://youtu.be/YaQYrVQDPHE?t=6s :) |
`config.action_controller.relative_url_root` can be used to tell Rails that you are deploying to a subdirectory. The default is `ENV['RAILS_RELATIVE_URL_ROOT']`. the asset pipeline doesn't like using the value from request script_name, although this should contain the correct value and should theoretically be possible :(
…o, remove font for comments * the comments should use the same font as the page they are embedded in
|
I removed the hack to auto-detect the subdir mount; as i was migration juvia to rails 4 the hack broke, and the internal handling got way too complicated to workaround it again. This also means that I didn't test it; my previous tests were done on my main juvia instance which was mounted at different urls, but now is only mounted at '/' (you can configure only one static subdir). |
