-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uncaught compile error #200
Comments
I remember that, one thing worth noticed is that, in current repository, it can't even do a successful build at all in my local: For example: https://github.com/pi-base/data/blob/main/spaces/S000171/properties/P000018.md?plain=1 have an empty description, so I comment it out months ago and forget it. But in the official online version it keeps running. |
The things more outrageous was that, backend has no logic to deduce contradiction: web/packages/compile/src/validations.ts Lines 15 to 23 in 0b8853e
Only frontend has and it didn't report to user: web/packages/viewer/src/stores/deduction.ts Lines 121 to 125 in 0b8853e
|
@jamesdabbs should have some time to review your PR in the coming weeks. FWIW the backend used to check for errors as compile time, but maybe this was accidentally looked over when we transitioned from https://github.com/pi-base/compile to https://github.com/pi-base/web |
I believe https://github.com/pi-base/data/tree/82a8e40903b87c395d5ec4acb75bea07abfe69dd has an error (asserting that the empty space is strongly Choquet), but for some reason it wasn't caught during the compile action...
The text was updated successfully, but these errors were encountered: